Skip to content

[Fix](Hive)Hive queries can potentially hit an NPE when running in the batch model. #60648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CalvinKirs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix](Hive)Hive queries can potentially hit an NPE when running in the batch model. #60648

CalvinKirs wants to merge 1 commit into from
+252 −38

Conversation

@CalvinKirs
Copy link
Member

@CalvinKirs CalvinKirs commented Feb 10, 2026

No description provided.

@Thearas
Copy link
Contributor

Thearas commented Feb 10, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@CalvinKirs
Copy link
Member Author

CalvinKirs commented Feb 10, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Feb 10, 2026

TPC-H: Total hot run time: 30820 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eb422c5b50f1c7c9a28cf833832514c8d160ab03, data reload: false

------ Round 1 ----------------------------------
q1	17644	4487	4292	4292
q2	2007	356	236	236
q3	10181	1272	718	718
q4	10195	774	313	313
q5	7501	2188	1941	1941
q6	191	177	143	143
q7	877	745	600	600
q8	9275	1397	1082	1082
q9	4719	4649	4655	4649
q10	6832	1942	1533	1533
q11	486	268	243	243
q12	350	381	228	228
q13	17804	4050	3258	3258
q14	228	237	212	212
q15	877	805	788	788
q16	698	677	616	616
q17	674	774	574	574
q18	6533	6094	6090	6090
q19	1667	1112	647	647
q20	612	552	428	428
q21	2809	2046	1962	1962
q22	364	322	267	267
Total cold run time: 102524 ms
Total hot run time: 30820 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4553	4473	4609	4473
q2	278	361	270	270
q3	2381	2875	2391	2391
q4	1519	1922	1494	1494
q5	4638	4974	4499	4499
q6	237	181	140	140
q7	2010	1920	1772	1772
q8	2625	2409	2386	2386
q9	7701	7426	7430	7426
q10	2798	2966	2589	2589
q11	493	448	419	419
q12	1032	744	597	597
q13	3851	4185	3253	3253
q14	270	281	251	251
q15	823	793	779	779
q16	642	691	632	632
q17	1065	1266	1341	1266
q18	7685	7311	7229	7229
q19	855	791	792	791
q20	1956	1997	1920	1920
q21	4621	4260	4059	4059
q22	487	467	407	407
Total cold run time: 52520 ms
Total hot run time: 49043 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2026

TPC-DS: Total hot run time: 190663 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eb422c5b50f1c7c9a28cf833832514c8d160ab03, data reload: false

query5	4775	634	514	514
query6	352	238	214	214
query7	4223	485	284	284
query8	331	247	243	243
query9	8773	2743	2766	2743
query10	539	350	345	345
query11	16689	16484	16149	16149
query12	179	125	119	119
query13	1277	470	376	376
query14	6438	3216	3008	3008
query14_1	2831	2818	2821	2818
query15	199	194	172	172
query16	980	476	452	452
query17	1083	690	594	594
query18	2590	444	343	343
query19	211	206	182	182
query20	131	126	125	125
query21	219	146	123	123
query22	4784	4968	4989	4968
query23	19086	18530	18211	18211
query23_1	18386	18270	18387	18270
query24	7230	1651	1216	1216
query24_1	1228	1218	1232	1218
query25	554	464	418	418
query26	1239	273	154	154
query27	2758	470	302	302
query28	4500	1861	1872	1861
query29	788	527	445	445
query30	309	245	211	211
query31	844	737	643	643
query32	88	73	78	73
query33	505	336	277	277
query34	933	914	571	571
query35	633	680	606	606
query36	1109	1096	959	959
query37	145	101	84	84
query38	2981	2958	2877	2877
query39	942	909	896	896
query39_1	883	868	865	865
query40	223	134	114	114
query41	64	60	61	60
query42	102	107	99	99
query43	445	418	415	415
query44	1389	727	725	725
query45	193	190	183	183
query46	883	978	610	610
query47	2084	2160	2087	2087
query48	314	325	235	235
query49	610	440	346	346
query50	692	279	210	210
query51	4132	4078	3969	3969
query52	99	108	93	93
query53	296	322	276	276
query54	289	269	270	269
query55	87	83	78	78
query56	310	310	297	297
query57	1408	1351	1248	1248
query58	272	258	262	258
query59	2081	2208	1912	1912
query60	332	332	312	312
query61	151	142	148	142
query62	605	568	505	505
query63	299	275	269	269
query64	4765	1212	951	951
query65	4541	4424	4467	4424
query66	1418	447	329	329
query67	16396	16368	16214	16214
query68	2443	1075	735	735
query69	409	317	286	286
query70	993	947	974	947
query71	332	325	303	303
query72	2902	2704	2566	2566
query73	521	552	316	316
query74	9818	9767	9555	9555
query75	2790	2770	2435	2435
query76	2291	1072	650	650
query77	344	373	292	292
query78	11421	11506	10878	10878
query79	1099	950	596	596
query80	752	551	491	491
query81	512	286	254	254
query82	1352	151	113	113
query83	354	259	234	234
query84	252	123	87	87
query85	883	475	407	407
query86	384	298	295	295
query87	3183	3077	2983	2983
query88	3594	2681	2662	2662
query89	388	349	315	315
query90	1832	176	170	170
query91	158	160	132	132
query92	74	76	73	73
query93	902	868	478	478
query94	576	327	295	295
query95	587	399	329	329
query96	648	527	227	227
query97	2461	2504	2401	2401
query98	232	215	210	210
query99	941	910	879	879
Total cold run time: 262809 ms
Total hot run time: 190663 ms

@doris-robot
Copy link

doris-robot commented Feb 10, 2026

ClickBench: Total hot run time: 28.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eb422c5b50f1c7c9a28cf833832514c8d160ab03, data reload: false

query1	0.05	0.04	0.05
query2	0.09	0.04	0.04
query3	0.25	0.09	0.08
query4	1.61	0.11	0.10
query5	0.27	0.25	0.26
query6	1.16	0.68	0.67
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.57	0.51	0.49
query10	0.54	0.53	0.55
query11	0.15	0.09	0.09
query12	0.14	0.10	0.11
query13	0.62	0.61	0.62
query14	1.06	1.05	1.05
query15	0.87	0.86	0.86
query16	0.41	0.38	0.39
query17	1.15	1.13	1.15
query18	0.22	0.20	0.21
query19	2.12	2.03	2.05
query20	0.01	0.02	0.01
query21	15.40	0.25	0.16
query22	5.17	0.06	0.05
query23	16.06	0.28	0.11
query24	1.44	0.73	0.93
query25	0.07	0.05	0.06
query26	0.15	0.14	0.13
query27	0.07	0.05	0.05
query28	4.64	1.12	0.97
query29	12.55	3.87	3.17
query30	0.28	0.13	0.12
query31	2.81	0.62	0.41
query32	3.23	0.59	0.50
query33	3.26	3.21	3.34
query34	16.15	5.38	4.70
query35	4.76	4.85	4.81
query36	0.64	0.50	0.50
query37	0.11	0.06	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.04
query40	0.19	0.16	0.15
query41	0.08	0.04	0.03
query42	0.04	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 98.66 s
Total hot run time: 28.76 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 10, 2026

FE Regression Coverage Report

Increment line coverage 5.26% (2/38) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CalvinKirs @Thearas @doris-robot @hello-stephen